junrushao1994 commented on pull request #8775: URL: https://github.com/apache/tvm/pull/8775#issuecomment-901778600
As the moderator in this thread, I do expect sufficient discussion as an architectural change. Let’s keep the discussion purely technical as we always enjoy in the community :-) We have already done great work moving to TE compiler. It seems that there are some final sticky points we wanted to address. Yep Cody is right and I was wrong. I just checked and saw several python functions registered in compile_engine.py still in use by TE compiler. We might want to move them to te_compiler.py. Lily, Cody is referring to some methods implemented in python instead of c++. Although it doesn’t actually cause divergent code path right now, we are not in favor of mixing c++ and python if there is no specific reason. So as you said, we might want to migrate them to c++ some day in the future. The input tensors are not exposed by methods in te compiler, which I assume is a fixable thing? Would you guys like to discuss more specifically on this? Do we want to slightly tweak the interface or add a new API to make it happen? Would you to hear concrete proposals from you guys! Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
