khionu commented on a change in pull request #8725:
URL: https://github.com/apache/tvm/pull/8725#discussion_r692601816
##########
File path: rust/tvm-rt/src/function.rs
##########
@@ -291,12 +299,12 @@ where
}
pub fn register_untyped<S: Into<String>>(
- f: fn(Vec<ArgValue<'static>>) -> Result<RetValue>,
+ f: for<'a> fn(Vec<ArgValue<'a>>) -> Result<RetValue>,
name: S,
override_: bool,
) -> Result<()> {
- // TODO(@jroesch): can we unify all the code.
- let func = f.to_function();
+ // // TODO(@jroesch): can we unify all the code.
Review comment:
Redundant comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
