jroesch commented on a change in pull request #8725:
URL: https://github.com/apache/tvm/pull/8725#discussion_r693244907
##########
File path: rust/tvm-rt/src/function.rs
##########
@@ -196,8 +204,8 @@ impl TryFrom<RetValue> for Function {
}
}
-impl<'a> From<Function> for ArgValue<'a> {
- fn from(func: Function) -> ArgValue<'a> {
+impl<'a> From<&Function> for ArgValue<'a> {
Review comment:
I think its probably still good to constrain here, the problem is the 'a
is sort of a phantom lifetime and we should probably use the `impl` to tie them
together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
