vegaluisjose commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r695258429
##########
File path: cmake/modules/VTA.cmake
##########
@@ -73,15 +73,28 @@ elseif(PYTHON)
# Cycle accurate simulator driver build
if(USE_VTA_TSIM)
+ if(DEFINED ENV{VERILATOR_INC_DIR})
+ set(VERILATOR_INC_DIR $ENV{VERILATOR_INC_DIR})
+ elseif (EXISTS /usr/local/share/verilator/include)
+ set(VERILATOR_INC_DIR /usr/local/share/verilator/include)
+ elseif (EXISTS /usr/share/verilator/include)
+ set(VERILATOR_INC_DIR /usr/share/verilator/include)
+ else()
+ message(STATUS "Verilator not found in
/usr/local/share/verilator/include")
+ message(STATUS "Verilator not found in /usr/share/verilator/include")
+ message(FATAL_ERROR "Cannot find Verilator, VERILATOR_INC_DIR is not
defined")
+ endif()
Review comment:
Sweet!
##########
File path: tests/scripts/task_config_build_cpu.sh
##########
@@ -34,7 +34,6 @@ echo set\(USE_NNPACK ON\) >> config.cmake
echo set\(NNPACK_PATH /NNPACK/build/\) >> config.cmake
echo set\(USE_ANTLR ON\) >> config.cmake
echo set\(CMAKE_CXX_COMPILER g++\) >> config.cmake
-echo set\(CMAKE_CXX_FLAGS -Werror\) >> config.cmake
Review comment:
Can we try pulling this back?..so others can see the issue in the CI log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
