aasorokiin commented on a change in pull request #8797: URL: https://github.com/apache/tvm/pull/8797#discussion_r693547334
########## File path: cmake/modules/VTA.cmake ########## @@ -73,15 +73,30 @@ elseif(PYTHON) # Cycle accurate simulator driver build if(USE_VTA_TSIM) + if(NOT DEFINED ENV{VERILATOR_INC_DIR}) Review comment: sorry, I don't quite get it. I see several reasons CI build fails. 1. ci_arm. No "RUN bash /install/ubuntu_install_verilator.sh" in docker/Dockerfile.ci_arm. As a result "Verilator not found" 2. ci_i386. Verilator was found, but __STDC_FORMAT_MACROS is unconditionally redefined in Verilator source and causes compilation error with -Werror 3. ci_gpu. TSIM is enabled for some reason. Verilator is not installed in docker file. "Verilator not found." So Cmake script looks working, but Verilator is not present in all scripts that build TSIM. And when it is present, tsim lib cannot compile because of Verilator source quality and -Werror requirement. @vegaluisjose -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org