mbs-octoml commented on pull request #8835: URL: https://github.com/apache/tvm/pull/8835#issuecomment-905573893
(3oz of coffee later) It will be the on-the-fly Target creation for the shape functions. By switching from String to Target we no longer implicitly identify distinct targets objects which have the same structure. To make this work we'll need to create all the Targets we need once and pass them around in the targets map. When lowering shape functions the target will need to be retrieved for the 'default cpu'. Again, eventually I'd like device planning to just spell this out, and for shape functions to have a well-defined place on which their appropriate Target annotation can be attached. As a stepping stone just passing in the 'default_cpu_target' or something would do? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
