junrushao1994 commented on pull request #8835: URL: https://github.com/apache/tvm/pull/8835#issuecomment-905745045
Hey Lily, I could imagine there are tons of challenges here and thank you for the really hard work! I feel like option 1 might be the most convenient way we could go with, although it still depends on string equality, but it will be fine if we end up removing these maps soon. More specifically, we can do: - Introduce `TargetStrHash` and `TargetStrEqual`, and put them temporarily somewhere in `src/relay/backend` folder, so that it won't be widely seen as public APIs - Add a note there that these two methods will be removed in the future, so that other developers could notice - Switch the `tvm::runtime::Map` to `std::unordered_map<Target, ..., TargetStrHash, TargetStrEqual>`, so that we are using the customized hash/equality methods - In the future, we can safely remove dependency to these two methods after the Target Map is completely removed :-) What do you think? Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
