Mousius commented on a change in pull request #8856:
URL: https://github.com/apache/tvm/pull/8856#discussion_r696702331
##########
File path: src/relay/backend/aot_executor_codegen.cc
##########
@@ -84,10 +84,7 @@ class AOTOnDemandAllocator : public ExprVisitor {
AssignReturnSid(GetRef<Expr>(op));
}
- void VisitExpr_(const VarNode* op) final {
- ExprVisitor::VisitExpr_(op);
- AssignReturnSid(GetRef<Expr>(op));
- }
+ void VisitExpr_(const VarNode* op) final {
AssignReturnSid(GetRef<Expr>(op)); }
Review comment:
There was no matching `VisitExpr` in `MixedModeVisitor`, given the tests
are passing for everything I've tried I'm at a loss for what it originally was
meant to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
