Mousius commented on a change in pull request #8856:
URL: https://github.com/apache/tvm/pull/8856#discussion_r696703378
##########
File path: src/relay/backend/aot_executor_codegen.cc
##########
@@ -437,7 +434,7 @@ class AOTExecutorCodegen : public ExprVisitor {
void VisitExpr_(const OpNode* op) override {
throw std::runtime_error("can not compile op in non-eta expanded form");
}
- void VisitExpr_(const GlobalVarNode* op) override { throw
std::runtime_error(""); }
+ void VisitExpr_(const GlobalVarNode* op) override {}
Review comment:
Honestly, no idea, subtle differences between the visitors lead it down
this path. After the changes to use the TE Compiler I understand why it would
end up here though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
