hogepodge commented on a change in pull request #8825: URL: https://github.com/apache/tvm/pull/8825#discussion_r696751895
########## File path: tutorials/optimize/opt_gemm.py ########## @@ -227,43 +228,49 @@ ################################################################################################### # Array Packing # ------------- -# Another important trick is array packing. This trick is to reorder the storage dimension of the -# array to convert the continuous access pattern on certain dimension to a sequential pattern after +# Another important trick is array packing. This trick is to reorder the storage dimension of an +# array to convert the continuous access pattern on its dimensions to a sequential pattern after # flattening. # # .. image:: https://github.com/dmlc/web-data/raw/main/tvm/tutorial/array-packing.png # :align: center # +# NOTE: The figure above is meant for illustration purposes only. Please ignore dimension Review comment: Stylistically I'm not a fan of asking someone to ignore something. Rather, just state what the illustration is. "This figure is a general illustration of how array packing works." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
