hogepodge commented on a change in pull request #8825:
URL: https://github.com/apache/tvm/pull/8825#discussion_r696767099



##########
File path: tutorials/optimize/opt_gemm.py
##########
@@ -227,43 +228,49 @@
 
###################################################################################################
 # Array Packing
 # -------------
-# Another important trick is array packing. This trick is to reorder the 
storage dimension of the
-# array to convert the continuous access pattern on certain dimension to a 
sequential pattern after
+# Another important trick is array packing. This trick is to reorder the 
storage dimension of an
+# array to convert the continuous access pattern on its dimensions to a 
sequential pattern after

Review comment:
       I would still say that "its dimension" is not correct grammar and is 
clumsy to read. Something more like: "Array packing reorders the storage 
pattern of an array, with the goal of changing a non-continuous access pattern 
in a given dimension to a sequential access pattern in that dimension."




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to