mbs-octoml commented on pull request #8795: URL: https://github.com/apache/tvm/pull/8795#issuecomment-906640059
On the py/cc split: I see the vela deps are mostly for instruction stream encoding and help checking dimenions etc are supported. Theoretically they could be ffi'd back into tvm. But even without that python/relay/backend/contrib/ethosu/tir/..., python/relay/backend/contraib/ethosu/codegen etc could be in cc, but can appreciate the convenience of staying mostly in py. As a compromise could you add type annots to the py code, particularly on callbacks reaching into tvm IR nodes? That would give me confidence we can spot when changes on the cc side would impact the py side. I left a comment on I think PR4 -- I've checked out and build PR6 which I'm using to see the big picture, so will sprinkle comments ahead as I go. I'm out of my depth for a few sections though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
