junrushao1994 commented on pull request #8892: URL: https://github.com/apache/tvm/pull/8892#issuecomment-909733923
Hey Jared, thanks for the PR! I understand the design of the virtual device id and it looks good to me if there are some use cases of it (usually we just assume it’s 0). On the other hand, there is direct correspondence between TargetKind to DLDeviceType, e.g. https://github.com/apache/tvm/blob/main/src/target/target_kind.cc#L278. So shall we just infer it from TargetNode::kind? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
