Mousius edited a comment on pull request #8892: URL: https://github.com/apache/tvm/pull/8892#issuecomment-910458796
> Is idea of TargetDevice to replace both Target and Device? And if we do replace Target with TargetDevice, how will we indicate that the Target for an expression has been set but not the Device? Thanks :) > On the other hand, there is direct correspondence between TargetKind to DLDeviceType, e.g. https://github.com/apache/tvm/blob/main/src/target/target_kind.cc#L278. So shall we just infer it from TargetNode::kind? These two comments together make me wonder if the correct mapping is directly from `Target` -> `Device` and from `TargetKind` to `DeviceType` rather than introducing a new structure? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
