areusch commented on a change in pull request #8955:
URL: https://github.com/apache/tvm/pull/8955#discussion_r703953475



##########
File path: tests/python/unittest/test_target_codegen_hexagon.py
##########
@@ -26,8 +26,10 @@
 import tvm.contrib.hexagon as hexagon
 
 
-# Register a phony linker, so that we can test codegen without a Hexagon 
toolchain.
-hexagon.register_linker(lambda: "/bin/true")
[email protected](scope="session", autouse=True)
+def register_linker():
+    # Register a phony linker, so that we can test codegen without a Hexagon 
toolchain.
+    hexagon.register_linker(lambda: "/bin/true")

Review comment:
       don't you need to unregister it after the test? e.g. 
https://docs.pytest.org/en/6.2.x/fixture.html#yield-fixtures-recommended and 
then un-register after the yield




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to