areusch commented on a change in pull request #8955: URL: https://github.com/apache/tvm/pull/8955#discussion_r706488089
########## File path: tests/python/unittest/test_target_codegen_hexagon.py ########## @@ -26,8 +26,10 @@ import tvm.contrib.hexagon as hexagon -# Register a phony linker, so that we can test codegen without a Hexagon toolchain. -hexagon.register_linker(lambda: "/bin/true") [email protected](scope="session", autouse=True) +def register_linker(): + # Register a phony linker, so that we can test codegen without a Hexagon toolchain. + hexagon.register_linker(lambda: "/bin/true") Review comment: tests don't run concurrently in the same python instance. if we do run tests concurrently, we use a different python interpreter (e.g. with xdist). a lot more stuff is gonna break if we run two tests concurrently in tvm. that said, i agree a better solution is probably to pass in the linker path rather than relying on system linker. up to you which route you want to go here--passing in the linker path is likely more invasive. however, if you choose to stick with this solution, could you unregister the global override (e.g. remember what it was before you registered new linker and set it back)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
