areusch commented on a change in pull request #9026:
URL: https://github.com/apache/tvm/pull/9026#discussion_r711327235
##########
File path: apps/microtvm/zephyr/template_project/microtvm_api_server.py
##########
@@ -59,44 +60,13 @@
# Data structure to hold the information microtvm_api_server.py needs
# to communicate with each of these boards.
-BOARD_PROPERTIES = {
- "qemu_x86": {
- "board": "qemu_x86",
- "model": "host",
- },
- "qemu_riscv32": {
- "board": "qemu_riscv32",
- "model": "host",
- },
- "qemu_riscv64": {
- "board": "qemu_riscv64",
- "model": "host",
- },
- "mps2_an521": {
- "board": "mps2_an521",
- "model": "mps2_an521",
- },
- "nrf5340dk_nrf5340_cpuapp": {
- "board": "nrf5340dk_nrf5340_cpuapp",
- "model": "nrf5340dk",
- },
- "stm32f746g_disco": {
- "board": "stm32f746g_disco",
- "model": "stm32f746xx",
- },
- "nucleo_f746zg": {
- "board": "nucleo_f746zg",
- "model": "stm32f746xx",
- },
- "nucleo_l4r5zi": {
- "board": "nucleo_l4r5zi",
- "model": "stm32l4r5zi",
- },
- "qemu_cortex_r5": {
- "board": "qemu_cortex_r5",
- "model": "zynq_mp_r5",
- },
-}
+BOARD_PROPERTIES = None
+BOARDS_FILE_NAME = "boards.json"
Review comment:
can you compute path relative to API_SERVER_DIR?
##########
File path: tests/micro/zephyr/conftest.py
##########
@@ -53,6 +56,24 @@ def zephyr_boards() -> dict:
ZEPHYR_BOARDS = zephyr_boards()
+def qemu_boards(board: str):
Review comment:
can we place test utils in a test_utils.py instead of conftest?
##########
File path: apps/microtvm/zephyr/template_project/microtvm_api_server.py
##########
@@ -294,6 +264,10 @@ def _get_nrf_device_args(options):
choices=[board["model"] for _, board in BOARD_PROPERTIES.items()],
help="Name of the model for each Zephyr board.",
),
+ server.ProjectOption(
+ "main_stack_size",
Review comment:
can we say main_stack_size_bytes or config_main_stack_size?
##########
File path: tests/micro/zephyr/test_zephyr.py
##########
@@ -58,6 +58,10 @@ def _make_sess_from_op(
def _make_session(temp_dir, zephyr_board, west_cmd, mod, build_config):
+ stack_size = None
Review comment:
can you use same variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
