gromero commented on a change in pull request #9026:
URL: https://github.com/apache/tvm/pull/9026#discussion_r711358099
##########
File path: python/tvm/micro/project.py
##########
@@ -101,7 +101,26 @@ def __init__(self, api_client):
if not self._info["is_template"]:
raise NotATemplateProjectError()
+ def _check_project_options(self, options: dict):
Review comment:
I'm wondering if it would be possible and better to rewrite that as
something like:
```
available_options = [option["name"] for option in
template.info()["project_options"]]
if not set(options.keys()).issubset(available_options):
raise ValueError(...)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
