comaniac commented on pull request #9061: URL: https://github.com/apache/tvm/pull/9061#issuecomment-925410911
Took a fast pass and had an offline discussion with @junrushao1994. Two major points: 1. The APIs are bit confusing (e.g.,`lookup_or_add` and `add`). It might be better to use something like `commit_workload` and `commit_record`. Meanwhile, since we may add more database implementations in the future (e.g., sqlite), this general API can also make sure we won't need to refine it again in AutoTIR. 2. Better to remove workload registry accordingly to make the design simple. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
