junrushao1994 commented on pull request #9061: URL: https://github.com/apache/tvm/pull/9061#issuecomment-925428557
Per discussion with @comaniac. The naming change: - `lookup_or_add` seems pretty random, and we should rename it as `commit_workload` which is more consistent with database terminologies - `add` seems okay but `commit_tuning_record` sounds better and more consistent with `commit_workload` Minor change in the code structure: - Consolidate `WorkloadRegistry` into `JSONFile` database, so that there is only one unified database API, and this could mimic the two-table database behavior -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
