Mousius commented on a change in pull request #31: URL: https://github.com/apache/tvm-rfcs/pull/31#discussion_r716699489
########## File path: rfcs/0031-devices-api.md ########## @@ -127,7 +127,7 @@ This simple wrapper enables type checking of these functions and defining a clea [reference-level-explanation]: #reference-level-explanation ## Entrypoint -The entrypoint API defined in [Embedded C Runtime Interface](https://discuss.tvm.apache.org/t/rfc-utvm-embedded-c-runtime-interface/9951) is augmented with the `devices` structure which contains implemented `tvm_device_t` `struct`s for each device used by the network: +The entrypoint API defined in [Embedded C Runtime Interface](https://discuss.tvm.apache.org/t/rfc-utvm-embedded-c-runtime-interface/9951) is augmented with the `tvm_mynetwork_devices` structure which contains implemented `tvm_device_t` `struct`s for each device used by the network: Review comment: I've intentionally left this as the C++ style as that's the current standard in TVM, @areusch suggested changing it [would likely require an RFC in itself and updating the style guide](https://github.com/apache/tvm/pull/8280#issuecomment-888554759). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
