Mousius commented on a change in pull request #31:
URL: https://github.com/apache/tvm-rfcs/pull/31#discussion_r716700036
##########
File path: rfcs/0031-devices-api.md
##########
@@ -41,7 +41,7 @@ In this example, you can see the diversity of RTOS
implementations for drivers a
[guide-level-explanation]: #guide-level-explanation
## User App
-`tvm_device_<device>_t`s are implemented for each RTOS or platform required,
these are included by the user who chooses as appropriate for their
application. Notably, to avoid dynamic allocation, the user must provide the
`tvm_device_<device>_t` struct and initialise it rather than it being created
and setup for them in the API. This is augmented by named functions for each
device, examples in the case of the "woofles" accelerator:
+TVM presumes that the RTOS, platform, or user application defines a struct
type `tvm_device_<device>_t`, these are included by the user who chooses an
implementation as appropriate for their application. Notably, to avoid dynamic
allocation, the user must provide the `tvm_device_<device>_t` struct and
initialise it rather than it being created and setup for them in the API. TVM
then expects an implementation of the named functions for each device, examples
in the case of the "woofles" accelerator:
Review comment:
Is this not covered by the example just below this block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
