[GitHub] [tvm] manupa-arm commented on a change in pull request #9160: [ETHOSN] Match config for is-supported with compilation target

Thu, 30 Sep 2021 08:37:16 -0700 


manupa-arm commented on a change in pull request #9160:
URL: https://github.com/apache/tvm/pull/9160#discussion_r719521619



##########
File path: src/relay/backend/contrib/ethosn/codegen.cc
##########
@@ -620,10 +626,10 @@ TVM_REGISTER_GLOBAL("relay.ethos-n.support.conv2d")
       auto err = EthosnAPI::QnnConv2d(call, &params);
       if (params.is_depthwise) {
         *rv = !err &&
-              m_Queries.IsDepthwiseConvolutionSupported(params.bias_info, 
params.weights_info,
+              m_Queries->IsDepthwiseConvolutionSupported(params.bias_info, 
params.weights_info,

Review comment:
       nit : might worth checking whether this is not null to ensure setup is 
called.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to