Leo-arm commented on a change in pull request #9160:
URL: https://github.com/apache/tvm/pull/9160#discussion_r720155921
##########
File path: src/relay/backend/contrib/ethosn/codegen.cc
##########
@@ -620,10 +626,10 @@ TVM_REGISTER_GLOBAL("relay.ethos-n.support.conv2d")
auto err = EthosnAPI::QnnConv2d(call, ¶ms);
if (params.is_depthwise) {
*rv = !err &&
- m_Queries.IsDepthwiseConvolutionSupported(params.bias_info,
params.weights_info,
+ m_Queries->IsDepthwiseConvolutionSupported(params.bias_info,
params.weights_info,
Review comment:
It works because only a default variant was supported. Once another
variant was selected, there was a mismatch between the variant that is used for
the IsSupported functionality and the actual compilation. This patch prepares
the way for that.
I restructured this a little to avoid having to call the setup from
elsewhere; it is now a self-contained change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
