areusch commented on issue #8953: URL: https://github.com/apache/tvm/issues/8953#issuecomment-933749770
ah i think i see what happened--since we started including the mangling and post-TE-compiler refactor, we haven't updated `TVM_CRT_MAX_STRLEN_FUNCTION_NAME` to match the new world (where it no longer maps 1:1 to kMaxFuncNameLength). it seems like we could either 1. update `TVM_CRT_MAX_STRLEN_FUNCTION_NAME` to mean "max length of the name, after adding all the extra stuff" 2. introduce length computations like you did above everywhere. i sort of prefer 1, and add a comment next to kMaxFuncNameLength to keep in sync with crt_config.h and vice versa. What do you think? this would be changing 80 to 120, then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
