areusch commented on issue #8953: URL: https://github.com/apache/tvm/issues/8953#issuecomment-940548495
@PhilippvK you are right, i think I see what happened here. #8380 was authored a long time ago and sync'd up several times, and i think as part of a "cleanup" these constants were changed from `TVM_CRT_STRLEN_NAME`. unfortunately looks like the cleanup was incomplete/wrong. it looks like there are also some places (e.g. https://github.com/apache/tvm/blob/main/src/runtime/crt/include/tvm/runtime/crt/internal/graph_executor/graph_executor.h#L63, but also grep for `[120]`) where we should have written `TVM_CRT_MAX_STRLEN_FUNCTION_NAME` instead. And, it looks like the places where we use `TVM_CRT_MAX_STRLEN_FUNCTION_NAME` are indeed parameters only. So it seems like the "correct" thing to do is to define `TVM_CRT_MAX_STRLEN_PARAM_NAME`, replace the current usages of `TVM_CRT_MAX_STRLEN_FUNCTION_NAME` with `TVM_CRT_MAX_STRLEN_PARAM_NAME`, and then fix up any residual `[120]` to be `TVM_CRT_MAX_STRLEN_FUNCTION_NAME`. sorry this is a bit more involved than originally anticipated... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
