Mousius commented on pull request #9208: URL: https://github.com/apache/tvm/pull/9208#issuecomment-936778921
> @Mousius If I understand this thread https://gitlab.kitware.com/cmake/cmake/-/issues/17365 correctly, and the cmake documentation (which says "New in version 3.20: Upstream GTestConfig.cmake is used if possible."), if the version of gtest is new enough (>=1.8) and cmake is new enough (>=3.20) then the `find_package(GTest)` will include a GMock target. Unfortunately, our required cmake version is much lower than 3.20 so we cannot rely on this feature. But right now we aren't using GMock are we? Hi @tkonolige, We don't currently use GMock, I have used it as part of https://github.com/apache/tvm/pull/9106 and have updated the CI images to include it with https://github.com/apache/tvm/pull/9107 and https://github.com/apache/tvm/pull/9141. It'd greatly help our ability to write good C++ tests to have GMock setup properly - although I'm only using the headers iirc so it works without referencing `gmock` or `gmock_main`. I'm also not going to suggest we don't do this until we figure all that out, I had just hoped it'd be easy enough to do :smile_cat: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
