kparzysz-quic commented on a change in pull request #9208:
URL: https://github.com/apache/tvm/pull/9208#discussion_r723589474
##########
File path: CMakeLists.txt
##########
@@ -585,22 +596,14 @@ endif()
# Create the `cpptest` target if we can find GTest. If not, we create dummy
# targets that give the user an informative error message.
-if(GTEST_INCLUDE_DIR AND GTEST_LIB)
+if(GTEST_FOUND)
file(GLOB_RECURSE TEST_SRCS tests/cpp/*.cc)
add_executable(cpptest ${TEST_SRCS})
- target_include_directories(cpptest SYSTEM PUBLIC ${GTEST_INCLUDE_DIR})
- target_link_libraries(cpptest PRIVATE ${TVM_TEST_LIBRARY_NAME} ${GTEST_LIB}
gtest_main pthread dl)
+ target_include_directories(cpptest SYSTEM PUBLIC ${GTEST_INCLUDE_DIRS})
+ target_link_libraries(cpptest PRIVATE ${TVM_TEST_LIBRARY_NAME}
${GTEST_BOTH_LIBRARIES} pthread dl)
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
