comaniac commented on a change in pull request #9248:
URL: https://github.com/apache/tvm/pull/9248#discussion_r727311387
##########
File path: python/tvm/autotvm/graph_tuner/utils/traverse_graph.py
##########
@@ -50,6 +51,8 @@ def expr2graph(expr, target_ops, node_dict, node_list):
Each node will be stored as a dictionary in the format of
{"op": str, "node": tvm.relay.expr, "inputs": [int], "types":
[tvm.relay.Type],
"name": str, "workloads": [tuple], "topi_op": [function]}
+
+ tvm_target : The TVM Target
Review comment:
Please follow the docstring format:
```
param_name: type
Description.
```
##########
File path: tests/python/unittest/test_autotvm_graph_tuner_utils.py
##########
@@ -57,7 +60,7 @@ def test_has_multiple_inputs():
target_ops = [relay.op.get("nn.conv2d")]
node_list = []
node_dict = {}
- expr2graph(net, target_ops, node_dict, node_list)
+ expr2graph(net, target_ops, node_dict, node_list,
tvm.target.target.Target("llvm"))
Review comment:
nit: could be just `tvm.target.Target("llvm")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
