rkimball commented on a change in pull request #9248:
URL: https://github.com/apache/tvm/pull/9248#discussion_r727253356



##########
File path: tests/python/unittest/test_autotvm_graph_tuner_utils.py
##########
@@ -155,6 +158,19 @@ def test_get_out_nodes():
         )
 
 
[email protected](
+    "target,expected",
+    [
+        pytest.param("llvm", "llvm -device=tracing"),
+        pytest.param("llvm -device=arm_cpu -arg=xxx", "llvm -device=tracing 
-arg=xxx"),
+        pytest.param("llvm -device=arm_cpu", "llvm -device=tracing"),
+        pytest.param("llvm -device=abc, def", "llvm -device=tracing"),

Review comment:
       The first test there checks where the device flag is at EOL which is a 
special case that needs to be tested.
   The second one has a space in the device flag items which is strange but I 
did find an example in the codebase here 
https://github.com/apache/tvm/blob/main/tests/python/driver/tvmc/test_tvmc_common.py#L267
   I added/changed some tests for cuda




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to