ashutosh-arm commented on a change in pull request #9331:
URL: https://github.com/apache/tvm/pull/9331#discussion_r733879032



##########
File path: src/relay/backend/contrib/cmsisnn/relay_to_tir.cc
##########
@@ -223,19 +353,25 @@ class RelayToTIRVisitor : public MixedModeVisitor {
 
     auto comp_name = func->GetAttr<String>(attr::kComposite);
     if (comp_name.defined()) {
-      if (comp_name == "cmsisnn.quantized_softmax") {
+      if (comp_name == "cmsisnn.qnn_conv2d") {
+        EmitConv2D(func->body);
+      }
+      if (comp_name == "cmsisnn.qnn_softmax") {
         EmitSoftMax(func->body);
       }
-      if (comp_name == "cmsisnn.quantized_mul") {
+      if (comp_name == "cmsisnn.qnn_mul") {
         EmitMul(func->body);
       }
-      if (comp_name == "cmsisnn.quantized_add") {
+      if (comp_name == "cmsisnn.qnn_add") {
         EmitAdd(func->body);
       }
     }
   }
 
  public:
+  int32_t kScaledDiffIntegerBits = 5;

Review comment:
       Nope. Moved some of them under private. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to