Mousius commented on a change in pull request #9331:
URL: https://github.com/apache/tvm/pull/9331#discussion_r733881775
##########
File path: src/relay/backend/contrib/cmsisnn/relay_to_tir.cc
##########
@@ -43,23 +44,153 @@ class RelayToTIRVisitor : public MixedModeVisitor {
inline IntImm ToArg(int32_t value) { return IntImm(DataType::Int(32),
value); }
void CreatePrimFuncForExtern(Array<tir::Var> func_signature,
- tvm::Array<PrimExpr> call_extern_args) {
+ tvm::Array<PrimExpr> call_extern_args, int
context_buffer_size = 0) {
Map<String, ObjectRef> dict_attrs;
dict_attrs.Set("global_symbol", func_name_);
dict_attrs.Set("tir.noalias", Bool(true));
tir::Stmt body = tir::Evaluate(
tvm::tir::Call(DataType::Int(8), tir::builtin::call_extern(),
call_extern_args));
+ if (context_buffer_size) {
+ // TODO(@ashutosh-arm) while supporting MVE, we need to move allocation
through TVMBAW
Review comment:
It seems to get generated on the stack anyway due to the heuristic so
far, but I didn't try `global.workspace` - why didn't that work here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
