Mousius commented on a change in pull request #9331:
URL: https://github.com/apache/tvm/pull/9331#discussion_r734665254
##########
File path: src/relay/backend/contrib/cmsisnn/tir_to_runtime.cc
##########
@@ -69,6 +225,10 @@ class CodeGenCMSISNN : public CodeGenC {
ss << "}\n";
ss << "#endif\n";
}
+
+ private:
Review comment:
Although it's not explicitly stated, I think the expectation is that by
grouping them you shouldn't repeat it
(https://google.github.io/styleguide/cppguide.html#Declaration_Order) - but as
I say, there's nothing explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
