manupa-arm commented on a change in pull request #9331: URL: https://github.com/apache/tvm/pull/9331#discussion_r734707629
########## File path: src/relay/backend/contrib/cmsisnn/extract_constants.cc ########## @@ -0,0 +1,158 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +#include <tvm/relay/attrs/nn.h> Review comment: TVM codebase do have unit tests for all the passes and I think we need *some* unit tests (apart from end to end tests). It would be great if we can have some common expected relay-based test cases. It would also aid in understanding what this pass is doing. Why should not we have unit tests ?, if we are committing this code ( we still want to commit this code irrespective of it being replaced by TIR constants right ? ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
