gromero commented on a change in pull request #9229:
URL: https://github.com/apache/tvm/pull/9229#discussion_r735769188
##########
File path: python/tvm/driver/tvmc/runner.py
##########
@@ -366,13 +460,17 @@ def run_module(
"Try calling tvmc.compile on the model before running it."
)
- # Currently only two package formats are supported: "classic" and
- # "mlf". The later can only be used for micro targets, i.e. with microTVM.
- if tvmc_package.type == "mlf":
- raise TVMCException(
- "You're trying to run a model saved using the Model Library Format
(MLF)."
- "MLF can only be used to run micro targets (microTVM)."
- )
+ micro = False
+ if device == "micro":
+ if tvmc_package.type != "mlf":
+ TVMCException("--device 'micro' specified but no MLF archive found
in PATH.")
Review comment:
Actually no command line is missing. This is catching the case when a
`model.tar` file is found in the project dir but it is a `classic` format, not
a MLF. I've tried to improve the message a bit anyway. Done in
https://github.com/apache/tvm/pull/9229/commits/8f6f6f682d40dd8a1b0c2cb8206956d81517663b
I also realized that I was not effectively calling `raise` there so no
exception was raised. I fixed that also in the commit above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
