gromero commented on a change in pull request #9229:
URL: https://github.com/apache/tvm/pull/9229#discussion_r735780219
##########
File path: python/tvm/micro/session.py
##########
@@ -107,7 +107,7 @@ def _wrap_transport_write(self, data, timeout_microsec):
return len(data) # TODO(areusch): delete
- def __enter__(self):
+ def open(self):
Review comment:
hmr actually I would like to add also the possibility to let the user
decide which mechanism he/she would like to use, with `with` (context manager)
or w/o a context manage, calling `open` and `close.
But accordingly to what we've discussed in the past I revered this change
and used `contextlib` to manage the context.
Reverted in:
https://github.com/apache/tvm/pull/9229/commits/42167f90a5b32055fad7b4f50d3f78e37e8dd15b
Kept the fix for the typo in:
https://github.com/apache/tvm/pull/9229/commits/bf94efe21f2045bd5933dcb98995ae7d4c0430f5
Use of contextlib in:
https://github.com/apache/tvm/pull/9229/commits/874382e6786d3996527d19e4002ee23d8e6c7c9f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
