NicolaLancellotti commented on a change in pull request #9384:
URL: https://github.com/apache/tvm/pull/9384#discussion_r738595885
##########
File path: tests/python/contrib/test_ethosu/test_codegen.py
##########
@@ -254,5 +254,93 @@ def representative_dataset():
infra.verify_source(compiled_models, accel_type)
[email protected](
+ "accel_type",
+ ACCEL_TYPES,
+)
[email protected]("pooling_type", ["MAX", "AVG"])
[email protected]("ifm_shape", [[1, 3, 4, 3], [1, 4, 5, 2]])
[email protected]("pool_shape, strides", [([1, 2], [1, 2]), ([2, 3],
[2, 3])])
[email protected]("activation_function", ["NONE", "RELU"])
[email protected]("padding", ["SAME", "VALID"])
Review comment:
Sounds good to me to group more things and have the test in a different
file.
##########
File path: python/tvm/relay/backend/contrib/ethosu/tir_to_cs_translator.py
##########
@@ -417,20 +418,22 @@ def _create_npu_op_conv2d(
return npu_conv2d_op, weights_zero_point
-def translate_ethosu_depthwise_conv2d(tir_extern_call):
- """This function will translate a tir extern_call
- as produced by Relay to TIR compilation.
+def translate_ethosu_depthwise_conv2d(
+ tir_extern_call: tvm.tir.Call,
+) -> Tuple[vapi.NpuConvDepthWiseOperation, int]:
+ """This function will translate a TIR call_extern
+ as produced by NPU Relay to TIR compilation.
Parameters
----------
tir_extern_call : tvm.tir.Call
- This should be a tir external call that has an agreed upon ordering
Review comment:
Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
