NicolaLancellotti commented on a change in pull request #9384:
URL: https://github.com/apache/tvm/pull/9384#discussion_r738597951
##########
File path: python/tvm/relay/backend/contrib/ethosu/tir_to_cs_translator.py
##########
@@ -370,10 +372,9 @@ def translate_ethosu_conv2d(tir_call_extern: tvm.tir.Call)
-> Tuple[vapi.NpuConv
The vela object containing the params of ethosu_conv2d
weights_zero_point : int
The zero point of the weights
-
"""
# We skip the first element as it is the call_extern function name
- serial_object = spec.create_serial_object(spec.Serial2DConvolution,
tir_call_extern.args[1:])
+ serial_object = spec.create_serial_object(spec.Serial2DConvolution,
tir_extern_call.args[1:])
Review comment:
I have refactored all the `translate_ethosu_*` functions to make them
similar, some functions used the parameter `tir_call_extern` and some
`tir_extern_call`. I'll change them all to` tir_call_extern`.
##########
File path: src/relay/op/contrib/ethosu/pooling.cc
##########
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file src/relay/op/contrib/ethosu/pooling.cc
+ * \brief Pooling operators definitions for the Arm(R) Ethos(TM)-U NPU
convolution ops.
+ */
+#include <tvm/relay/op.h>
+
+#include "common.h"
+
+namespace tvm {
+namespace relay {
+namespace op {
+namespace contrib {
+namespace ethosu {
+
+/*! \brief Attributes used by the Ethos(TM)-U NPU pooling operator */
+struct EthosuPoolingAttrs : public tvm::AttrsNode<EthosuPoolingAttrs> {
+ String pooling_type;
+ double ifm_scale;
+ int ifm_zero_point;
+ double ofm_scale;
+ int ofm_zero_point;
+ Array<IndexExpr> pool_shape;
+ IndexExpr ofm_channels;
+ Array<IndexExpr> strides;
+ Array<IndexExpr> padding;
+ String activation;
+ int clip_min;
+ int clip_max;
+ String upscale;
+ String ifm_layout;
+ String ofm_layout;
+
+ TVM_DECLARE_ATTRS(EthosuPoolingAttrs, "relay.attrs.EthosuPoolingAttrs") {
+ TVM_ATTR_FIELD(pooling_type)
+ .describe("The type of the pooling. 'AVG' - average pool, 'MAX' - max
pool.");
+ TVM_ATTR_FIELD(ifm_scale).describe("The quantization scale for the Input
Feature Map tensor.");
+ TVM_ATTR_FIELD(ifm_zero_point)
+ .describe("The quantization zero point for the Input Feature Map
tensor.");
+ TVM_ATTR_FIELD(ofm_scale).describe("The quantization scale for the Output
Feature Map tensor.");
+ TVM_ATTR_FIELD(ofm_zero_point)
+ .describe("The quantization zero point for the Output Feature Map
tensor.");
+ TVM_ATTR_FIELD(pool_shape)
+ .describe("The 2 dimensional pool shape as (pool_shape_height,
pool_shape_width).")
+ .set_default(NullValue<Array<IndexExpr> >());
+ TVM_ATTR_FIELD(ofm_channels)
+ .describe(" The number of OFM channels.")
Review comment:
Ack
##########
File path: src/relay/op/contrib/ethosu/pooling.cc
##########
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file src/relay/op/contrib/ethosu/pooling.cc
+ * \brief Pooling operators definitions for the Arm(R) Ethos(TM)-U NPU
convolution ops.
+ */
+#include <tvm/relay/op.h>
+
+#include "common.h"
+
+namespace tvm {
+namespace relay {
+namespace op {
+namespace contrib {
+namespace ethosu {
+
+/*! \brief Attributes used by the Ethos(TM)-U NPU pooling operator */
+struct EthosuPoolingAttrs : public tvm::AttrsNode<EthosuPoolingAttrs> {
+ String pooling_type;
+ double ifm_scale;
+ int ifm_zero_point;
+ double ofm_scale;
+ int ofm_zero_point;
+ Array<IndexExpr> pool_shape;
+ IndexExpr ofm_channels;
+ Array<IndexExpr> strides;
+ Array<IndexExpr> padding;
+ String activation;
+ int clip_min;
+ int clip_max;
+ String upscale;
+ String ifm_layout;
+ String ofm_layout;
+
+ TVM_DECLARE_ATTRS(EthosuPoolingAttrs, "relay.attrs.EthosuPoolingAttrs") {
+ TVM_ATTR_FIELD(pooling_type)
+ .describe("The type of the pooling. 'AVG' - average pool, 'MAX' - max
pool.");
+ TVM_ATTR_FIELD(ifm_scale).describe("The quantization scale for the Input
Feature Map tensor.");
+ TVM_ATTR_FIELD(ifm_zero_point)
+ .describe("The quantization zero point for the Input Feature Map
tensor.");
+ TVM_ATTR_FIELD(ofm_scale).describe("The quantization scale for the Output
Feature Map tensor.");
+ TVM_ATTR_FIELD(ofm_zero_point)
+ .describe("The quantization zero point for the Output Feature Map
tensor.");
+ TVM_ATTR_FIELD(pool_shape)
+ .describe("The 2 dimensional pool shape as (pool_shape_height,
pool_shape_width).")
+ .set_default(NullValue<Array<IndexExpr> >());
+ TVM_ATTR_FIELD(ofm_channels)
+ .describe(" The number of OFM channels.")
+ .set_default(NullValue<IndexExpr>());
+ TVM_ATTR_FIELD(strides)
+ .set_default(Array<IndexExpr>({1, 1}))
+ .describe("The 2 dimensional strides as (stride_height,
stride_width).");
+ TVM_ATTR_FIELD(padding)
+ .describe("The 4 dimensional padding as (pad_top, pad_left,
pad_bottom, pad_right).")
+ .set_default(Array<IndexExpr>({0, 0, 0, 0}));
+ TVM_ATTR_FIELD(activation)
+ .describe(
+ "The activation function to use. "
+ "'NONE' - no activation function. "
+ "'CLIP' - clip the output between clip_min and clip_max. "
+ "'TANH' - tanh activation function. "
+ "'SIGMOID' - sigmoid activation function. "
+ "'LUT' - use a look-up table to perform the activation function.")
+ .set_default("NONE");
+ TVM_ATTR_FIELD(clip_min)
+ .describe("The minimum clipping value if activation = 'CLIP'.")
+ .set_default(0);
+ TVM_ATTR_FIELD(clip_max)
+ .describe("The maximum clipping value if activation = 'CLIP'.")
+ .set_default(0);
+ TVM_ATTR_FIELD(upscale)
+ .describe(
+ "The 2x2 upscaling mode to apply to the Input Feature Map tensor. "
+ "'NONE' - no upscaling. "
+ "'NEAREST' - upscale using nearest neighbour. "
+ "'ZEROS' - upscale using zeros.")
+ .set_default("NONE");
+ TVM_ATTR_FIELD(ifm_layout)
+ .describe("The layout of the Input Feature Map tensor. Can be 'NHWC'
or 'NHCWB16'.")
+ .set_default("NHWC");
+ TVM_ATTR_FIELD(ofm_layout)
+ .describe("The layout of the Output Feature Map tensor. Can be 'NHWC'
or 'NHCWB16'.")
+ .set_default("NHWC");
+ }
+};
+
+TVM_REGISTER_NODE_TYPE(EthosuPoolingAttrs);
+
+bool EthosuPoolingRel(const Array<Type>& types, int num_inputs, const Attrs&
attrs,
+ const TypeReporter& reporter) {
+ int ifm_index = 0;
+ int result_index = 2;
+ ICHECK_EQ(types.size(), result_index + 1);
+
+ const auto* ifm = types[ifm_index].as<TensorTypeNode>();
+ if (ifm == nullptr) return false;
+
+ const auto* param = attrs.as<EthosuPoolingAttrs>();
+ ICHECK(param != nullptr) << "EthosuPoolingAttrs cannot be nullptr.";
+
+ bool is_avg_pooling = param->pooling_type == "AVG";
+ ICHECK(is_avg_pooling || param->pooling_type == "MAX")
+ << "Expected pooling_type 'AVG' or 'MAX' but was" << param->pooling_type;
+
+ ICHECK(ifm->dtype == DataType::UInt(8) || ifm->dtype == DataType::Int(8))
+ << "Expected pool type(uint8) or type(int8) for ifm but was " <<
ifm->dtype;
+
+ // Assign ofm type
+ auto ofm_shape = EthosuInferKernelOutput(
+ ifm->shape, param->ifm_layout, param->ofm_layout, param->pool_shape,
param->ofm_channels,
+ Array<IndexExpr>({1, 1}), param->strides, param->padding);
+ reporter->Assign(types[result_index], TensorType(ofm_shape, ifm->dtype));
+ return true;
+}
+
+Expr MakeEthosuPooling(Expr ifm, Expr lut, String pooling_type, double
ifm_scale,
+ int ifm_zero_point, double ofm_scale, int
ofm_zero_point,
+ Array<IndexExpr> pool_shape, IndexExpr ofm_channels,
+ Array<IndexExpr> strides, Array<IndexExpr> padding,
String activation,
+ int clip_min, int clip_max, String upscale, String
ifm_layout,
+ String ofm_layout) {
+ auto attrs = make_object<EthosuPoolingAttrs>();
+ attrs->pooling_type = pooling_type;
Review comment:
Ack
##########
File path: tests/python/contrib/test_ethosu/test_type_inference.py
##########
@@ -92,5 +93,38 @@ def test_ethosu_depthwise_conv2d_type_inference(
assert tuple(f.body.checked_type.shape) == ofm_shape
[email protected](
+ "ifm_shape, ifm_layout", [((1, 56, 72, 55), "NHWC"), ((1, 56, 4, 72, 16),
"NHCWB16")]
+)
[email protected](
+ "ofm_shape, ofm_layout", [((1, 56, 38, 55), "NHWC"), ((1, 56, 4, 38, 16),
"NHCWB16")]
+)
+def test_ethosu_pooling_type_inference(
+ ifm_shape,
+ ifm_layout,
+ ofm_shape,
+ ofm_layout,
+):
+ ifm = relay.var("ifm", shape=ifm_shape, dtype="int8")
+ pooling_type = "AVG"
+ pool_shape = (3, 2)
+ ofm_channels = 55
+ strides = (1, 2)
+ padding = (0, 1, 2, 3)
+ pooling = make_ethosu_pooling(
+ ifm,
+ pooling_type,
+ pool_shape,
+ ofm_channels,
+ strides,
+ padding,
+ ifm_layout=ifm_layout,
+ ofm_layout=ofm_layout,
+ )
+ f = relay.Function([ifm], pooling)
+ f = run_opt_pass(f, relay.transform.InferType())
+ assert tuple(f.body.checked_type.shape) == ofm_shape
Review comment:
Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
