tqchen commented on a change in pull request #9313:
URL: https://github.com/apache/tvm/pull/9313#discussion_r740466523
##########
File path: src/ir/attr_functor.h
##########
@@ -105,6 +106,7 @@ class AttrFunctor<R(const ObjectRef& n, Args...)> {
virtual R VisitAttr_(const tir::CastNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
virtual R VisitAttr_(const tir::CallNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
virtual R VisitAttr_(const tir::SelectNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
+ virtual R VisitAttr_(const SEScopeNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
Review comment:
Would be nice to leave as a TODO if we do not plan to handle directly
here.
##########
File path: src/ir/attr_functor.h
##########
@@ -105,6 +106,7 @@ class AttrFunctor<R(const ObjectRef& n, Args...)> {
virtual R VisitAttr_(const tir::CastNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
virtual R VisitAttr_(const tir::CallNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
virtual R VisitAttr_(const tir::SelectNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
+ virtual R VisitAttr_(const SEScopeNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
Review comment:
I personally agree that equality hashing on Target is the way to go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
