mbs-octoml commented on a change in pull request #9313:
URL: https://github.com/apache/tvm/pull/9313#discussion_r740655169
##########
File path: src/ir/attr_functor.h
##########
@@ -105,6 +106,7 @@ class AttrFunctor<R(const ObjectRef& n, Args...)> {
virtual R VisitAttr_(const tir::CastNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
virtual R VisitAttr_(const tir::CallNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
virtual R VisitAttr_(const tir::SelectNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
+ virtual R VisitAttr_(const SEScopeNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
Review comment:
Just gotten back to this -- so we agree adding equality & hash on Target
is the way forward? We'll have to do that if we want SEScope to be 'just an
attrs', right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
