ashutosh-arm commented on a change in pull request #9331:
URL: https://github.com/apache/tvm/pull/9331#discussion_r743830843
##########
File path: python/tvm/relay/op/contrib/cmsisnn.py
##########
@@ -52,37 +54,85 @@ def partition_for_cmsisnn(mod, params=None, **opts):
transform.InferType(),
transform.MergeComposite(pattern_table()),
transform.AnnotateTarget("cmsisnn"),
- transform.MergeCompilerRegions(),
Review comment:
Enabling this pass gets us the latter one. Irrespective of the Relay
that we get post partitioning, RelayToTIR works on composite functions each one
of which is translated into a separate primfunc. So, independent of the pass,
atm, we end up producing multiple '.c'.
We made the choice of having separate primfunc per operator to get away with
the bookkeeping required in RelayToTIR at the cost of having to invoke
different C functions at runtime.
@Mousius you want to add something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
