Mousius commented on a change in pull request #9331:
URL: https://github.com/apache/tvm/pull/9331#discussion_r743859261
##########
File path: python/tvm/relay/op/contrib/cmsisnn.py
##########
@@ -52,37 +54,85 @@ def partition_for_cmsisnn(mod, params=None, **opts):
transform.InferType(),
transform.MergeComposite(pattern_table()),
transform.AnnotateTarget("cmsisnn"),
- transform.MergeCompilerRegions(),
Review comment:
With https://github.com/apache/tvm/pull/9397 the `Target` will produce a
single `IRModule` into `runtime::Module` rather than creating many so the
functions are just wrappers around the CMSIS-NN calls after that which
essentially create the CMSIS-NN structures and call them so that seems the
minimal amount for them other than packing multiple CMSIS-NN API calls into a
single PrimFunc which we didn't intend to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
