gromero commented on a change in pull request #9584:
URL: https://github.com/apache/tvm/pull/9584#discussion_r758739053



##########
File path: python/tvm/micro/project.py
##########
@@ -56,6 +56,17 @@ def read(self, n, timeout_sec):
         return self._api_client.read_transport(n, timeout_sec)["data"]
 
 
+def prepare_options(received_options: dict, all_options: dict) -> dict:

Review comment:
       @mehrdadh `options.get()` I'll take care of it. For instance, in that 
environment `arduinoc_cli` can be found and TVMC says `Defaults to 
'/home/gromero/bin/arduino-cli'.` But user can force another cli path like I do 
in the second example below by forcing 
`arduino_cli_cmd=/nonexiting_arduino_cli`:
   
   ```
   gromero@amd:~/git/tvm$ tvmc micro create --force /tmp/x9584 
~/scripts/sine.tar arduino --project-option project_type=host_driven 
--list-options 
   usage: tvmc micro create-project project_dir MLF arduino --project-option 
OPTION=VALUE [OPTION=VALUE ...] [-h]
   
   optional arguments:
     --project-option OPTION=VALUE [OPTION=VALUE ...]
                           arduino_cli_cmd=ARDUINO_CLI_CMD
                             path to the arduino-cli tool. Defaults to 
'/home/gromero/bin/arduino-cli'.
                           
                           project_type={example_project, host_driven}
                             type of project to generate. (required)
                           
                           warning_as_error={true, false}
                             treat warnings as errors and raise an Exception.
                           
     -h, --help, --list-options
                           show this help message which includes 
platform-specific options and exit.
   gromero@amd:~/git/tvm$ tvmc micro create --force /tmp/x9584 
~/scripts/sine.tar arduino --project-option project_type=host_driven 
arduino_cli_cmd=/nonexiting_arduino_cli
   [21:07:58] /home/gromero/git/tvm/src/target/target_kind.cc:191: Warning: 
Unable to detect CUDA version, default to "-mcpu=sm_20" instead
   [21:07:58] /home/gromero/git/tvm/src/target/target_kind.cc:217: Warning: 
Unable to detect ROCm compute arch, default to "-mcpu=gfx900" instead
   [21:07:58] /home/gromero/git/tvm/src/target/target_kind.cc:231: Warning: 
Unable to detect ROCm version, assuming >= 3.5
   [21:07:58] /home/gromero/git/tvm/src/target/target_kind.cc:163: Warning: 
Unable to detect CUDA version, default to "-arch=sm_20" instead
   [21:07:58] /home/gromero/git/tvm/src/target/target_kind.cc:191: Warning: 
Unable to detect CUDA version, default to "-mcpu=sm_20" instead
   [21:07:58] /home/gromero/git/tvm/src/target/target_kind.cc:217: Warning: 
Unable to detect ROCm compute arch, default to "-mcpu=gfx900" instead
   [21:07:58] /home/gromero/git/tvm/src/target/target_kind.cc:231: Warning: 
Unable to detect ROCm version, assuming >= 3.5
   [21:07:58] /home/gromero/git/tvm/src/target/target_kind.cc:163: Warning: 
Unable to detect CUDA version, default to "-arch=sm_20" instead
   The following error occured on the Project API server side: 
    calling method generate_project: JSON-RPC error # -32000: calling method 
generate_project
   Traceback (most recent call last):
     File "/home/gromero/git/tvm/python/tvm/micro/project_api/server.py", line 
481, in serve_one_request  # <--- Outermost server-side stack frame
       self._dispatch_request(request)
     File "/home/gromero/git/tvm/python/tvm/micro/project_api/server.py", line 
593, in _dispatch_request
       return_value = dispatch_method(**params)
     File "/home/gromero/git/tvm/python/tvm/micro/project_api/server.py", line 
621, in _dispatch_generate_project
       return self._handler.generate_project(
     File 
"/home/gromero/git/tvm/build/microtvm_template_projects/arduino/microtvm_api_server.py",
 line 328, in generate_project
       version = self._get_platform_version(options)
     File 
"/home/gromero/git/tvm/build/microtvm_template_projects/arduino/microtvm_api_server.py",
 line 319, in _get_platform_version
       version_output = subprocess.check_output([arduino_cli_cmd, "version"], 
encoding="utf-8")
     File "/usr/lib/python3.9/subprocess.py", line 424, in check_output
       return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
     File "/usr/lib/python3.9/subprocess.py", line 505, in run
       with Popen(*popenargs, **kwargs) as process:
     File "/usr/lib/python3.9/subprocess.py", line 951, in __init__
       self._execute_child(args, executable, preexec_fn, close_fds,
     File "/usr/lib/python3.9/subprocess.py", line 1821, in _execute_child
       raise child_exception_type(errno_num, err_msg, err_filename)
   FileNotFoundError: [Errno 2] No such file or directory: 
'/nonexiting_arduino_cli'
   
   gromero@amd:~/git/tvm$ tvmc micro create --force /tmp/x9584 
~/scripts/sine.tar arduino --project-option project_type=host_driven 
   [21:08:09] /home/gromero/git/tvm/src/target/target_kind.cc:191: Warning: 
Unable to detect CUDA version, default to "-mcpu=sm_20" instead
   [21:08:09] /home/gromero/git/tvm/src/target/target_kind.cc:217: Warning: 
Unable to detect ROCm compute arch, default to "-mcpu=gfx900" instead
   [21:08:09] /home/gromero/git/tvm/src/target/target_kind.cc:231: Warning: 
Unable to detect ROCm version, assuming >= 3.5
   [21:08:09] /home/gromero/git/tvm/src/target/target_kind.cc:163: Warning: 
Unable to detect CUDA version, default to "-arch=sm_20" instead
   [21:08:09] /home/gromero/git/tvm/src/target/target_kind.cc:191: Warning: 
Unable to detect CUDA version, default to "-mcpu=sm_20" instead
   [21:08:09] /home/gromero/git/tvm/src/target/target_kind.cc:217: Warning: 
Unable to detect ROCm compute arch, default to "-mcpu=gfx900" instead
   [21:08:09] /home/gromero/git/tvm/src/target/target_kind.cc:231: Warning: 
Unable to detect ROCm version, assuming >= 3.5
   [21:08:09] /home/gromero/git/tvm/src/target/target_kind.cc:163: Warning: 
Unable to detect CUDA version, default to "-arch=sm_20" instead
   gromero@amd:~/git/tvm$ # works using the defaul ^
   gromero@amd:~/git/tvm$ 
   
   ```
   
   Isn't that so addressing your issue? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to