mehrdadh commented on a change in pull request #9584:
URL: https://github.com/apache/tvm/pull/9584#discussion_r759502789
##########
File path: apps/microtvm/arduino/template_project/microtvm_api_server.py
##########
@@ -78,7 +80,13 @@ class BoardAutodetectFailed(Exception):
),
server.ProjectOption(
"arduino_cli_cmd",
- required=["build", "flash", "open_transport"],
+ required=["generate_project", "build", "flash", "open_transport"]
+ if not ARDUINO_CLI_CMD
Review comment:
done
##########
File path: apps/microtvm/arduino/template_project/microtvm_api_server.py
##########
@@ -248,7 +256,12 @@ def _convert_includes(self, project_dir, source_dir):
for ext in ("c", "h", "cpp"):
for filename in source_dir.rglob(f"*.{ext}"):
with filename.open() as file:
- lines = file.readlines()
+ try:
+ lines = file.readlines()
+ # TODO: This exception only happens using `tvmc micro` and
is not catched on Arduino tests.
+ # Needs more investigation.
+ except UnicodeDecodeError:
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
