jhlee525 opened a new pull request #9677:
URL: https://github.com/apache/tvm/pull/9677


   Currently, the logic for finding `config.cmake` in `CMakeLists.txt` looks 
like this
   
   ```
   if(EXISTS ${CMAKE_CURRENT_BINARY_DIR}/config.cmake)
     include(${CMAKE_CURRENT_BINARY_DIR}/config.cmake)
   else()
     if(EXISTS ${CMAKE_CURRENT_SOURCE_DIR}/config.cmake)
       include(${CMAKE_CURRENT_SOURCE_DIR}/config.cmake)
     endif()
   endif()
   ```
   
   First, it searches from binary dir(usually ./build), then it goes to the 
source directory(./) if it does not exist. However, there is no config.cmake in 
the root directory, so I believe it does nothing.
   
   We can choose from various policies. For example, raising an error if not 
exist or ignoring to use `config.cmake`. I thought using the "sample" 
`cmake/config.cmake` is the most reasonable solution, I changed 
`CMakeLists.txt` to find from `./cmake` directory.
   
   It's my first time to commit in here, please let me know if there are any 
issues! 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to