jhlee525 edited a comment on pull request #9677:
URL: https://github.com/apache/tvm/pull/9677#issuecomment-990632727
If root directory is selected for cmake directory, the logic after `else()`
is unnecessary. Because in this case, `${CMAKE_CURRENT_BINARY_DIR}` is as same
as `${CMAKE_CURRENT_SOURCE_DIR}`.
And I think my version of modification also does not polute "example
config.cmake" because previous logic (copying config.cmake into cmake build
directory) is completely compatable.
The main benefit of this PR is to provide one-stop mode build, for the users
who does not want to configure thier own cmake settings.
But, it's not critical feature for running TVM, i think it would be fine to
just removing else() logic, or even keeping it as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
