ashutosh-arm commented on a change in pull request #9682:
URL: https://github.com/apache/tvm/pull/9682#discussion_r765076744
##########
File path: python/tvm/relay/op/contrib/cmsisnn.py
##########
@@ -227,7 +227,7 @@ def binary_op_pattern(op):
def check_qnn_binary_op(extract):
"""Check if multiply is supported by CMSIS-NN."""
- return (
+ return bool(
Review comment:
Tagging @leandron if he knows something about the
conv2d.attrs.padding[2] == 0 returning IntImm instead of bool. Its definitely
surprising.
I'd update the code to just cast the subexpression as that makes code more
readable, as you've suggested. Thanks @mshawcroft
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
