ashutosh-arm commented on pull request #9682: URL: https://github.com/apache/tvm/pull/9682#issuecomment-989807244
@manupa-arm If you look at the latest changes that I've pushed, it contains both: Fix for the exact issue and the corresponding test. The issue was that MergeComposite() failed because Conv2D's check function failed on cifar_10. By check function here, I mean the callback function registered with MergeComposite(). As you can see in the code snippet posted above in the comments, IntImm comparison was causing the equality to return non bool value: _conv2d.attrs.padding[2] == 0_ . As you pointed out, we are trying to access C++ fields from python here. Regarding the test, @u99127 suggested to add corresponding test which I've pushed with my last commit. This test is a negative test to introduce the negative padding that would trigger a failure in the check function. So, now we do have both the fix and the test as per reviewers' comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
