comaniac commented on a change in pull request #9729:
URL: https://github.com/apache/tvm/pull/9729#discussion_r768008092
##########
File path: include/tvm/ir/module.h
##########
@@ -57,6 +57,8 @@ class IRModuleNode : public Object {
Map<GlobalVar, BaseFunc> functions;
/*! \brief A map from global type vars to ADT type data. */
Map<GlobalTypeVar, TypeData> type_definitions;
+ /*! \brief The external module containing the external functions used by
this module. */
+ Array<runtime::Module> external_mods;
Review comment:
This is not a proper approach. @zhiics and I were trying to adopt the
similar approach when implementing BYOC, but we gave up and embarrassed
metadata module after discussing with @tqchen. In general, we should
differentiate `external` modules because all modules are unified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
