mbs-octoml commented on a change in pull request #9729:
URL: https://github.com/apache/tvm/pull/9729#discussion_r768029280
##########
File path: include/tvm/ir/module.h
##########
@@ -57,6 +57,8 @@ class IRModuleNode : public Object {
Map<GlobalVar, BaseFunc> functions;
/*! \brief A map from global type vars to ADT type data. */
Map<GlobalTypeVar, TypeData> type_definitions;
+ /*! \brief The external module containing the external functions used by
this module. */
+ Array<runtime::Module> external_mods;
Review comment:
As @electriclilies says we already have this, and it is already
essential to making IRModule the carrier for all passes, including the existing
BYOC (primitive function to runtime Module) and the TIRToRuntime extension
point from @Mousius .
Perhaps you are suggesting we need a way to represent 'already compiled'
functions that's not bound up with the runtime?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
